fix(bar): prevent outside text labels from overlapping tilted axis ticks#7872
fix(bar): prevent outside text labels from overlapping tilted axis ticks#7872vizansh wants to merge 3 commits into
Conversation
|
Thanks for the PR! Our team will review and provide feedback. |
|
Hi maintainers, could someone please approve and trigger the GitHub Actions workflow for this PR? I'd love to make sure all the automated CI/CD tests pass successfully. Thank you! |
|
Until we get to this review, could you please look into the test failures and see if anything is broken/needs to be updated? |
|
Hi @vizansh ! I just spent some time reviewing the original issue #7822, and posted a comment with my thoughts on the root cause and the best approach for a fix. I think the best fix will require a different approach than what you've done here. Please feel free to continue working and pursue one of the fix approaches outlined in my comment if you like, or propose another approach. I'm happy to review. |
3 participants
Fixes #7822
This pull request dynamically calculates the positioning for bar chart text labels when
textposition='outside'.Instead of using a static pixel margin, it looks up the active axis configuration and utilizes
.getBBox()to measure the exact live dimensions of the tilted or long axis labels. It then shifts the bar numbers by that precise footprint plus a clean visual buffer, entirely preventing overlaps with the top/right axis ticks.